Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialiser_Engine: Upgrade to Mongo version 2.18 #2949

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Serialiser_Engine: Upgrade to Mongo version 2.18 #2949

merged 3 commits into from
Nov 24, 2022

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 17, 2022

Issues addressed by this PR

Closes #2948

Test files

@adecler adecler added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Nov 17, 2022
@adecler adecler self-assigned this Nov 17, 2022
@adecler
Copy link
Member Author

adecler commented Nov 18, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2022

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 15 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the test scripts that we use for our end-of-milestone beta testing on the following concepts:

  • Serialisation
  • Versioning
  • Socket
  • Mongo Toolkit

All have passed satisfactorily to allow these to go to alpha for further review by alpha users. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 15 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 24 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9573794424

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9573786742

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9573794424

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9573786742

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd I have now provided a passing check on reference 9573794424 as requested.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd I have now provided a passing check on reference 9573786742 as requested.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on File_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on File_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on File_Toolkit

FraserGreenroyd
FraserGreenroyd approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the test scripts for the end of milestone and everything is still working happily.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9687376834

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9687371167

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

There are 13 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9687376834

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9687371167

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd I have now provided a passing check on reference 9687376834 as requested.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd I have now provided a passing check on reference 9687371167 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit ee6c13f into main Nov 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2948-UpgradeMongo branch November 24, 2022 12:28
@FraserGreenroyd FraserGreenroyd changed the title Upgrade to Mongo version 2.18 Serialiser_Engine: Upgrade to Mongo version 2.18 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher

@rwemay rwemay Awaiting requested review from rwemay

Assignees

@adecler adecler

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure the same version of MongoDB is used across all repos
2 participants
@adecler @FraserGreenroyd